Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async-friendly decompress #145

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

droundy
Copy link

@droundy droundy commented Jul 16, 2023

I started creating an alternate decompressor that would work better with async than the Read based one you have. The issue is that in my async program the bytes come over the network in chunks and I can't write a non-async Read without introducing additional plumbing that I'd rather avoid.

This PR isn't very good yet, but I'm wondering if something like this would be of interest to you?

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #145 (bfa4fc8) into main (23b05b0) will decrease coverage by 6.81%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   89.02%   82.21%   -6.81%     
==========================================
  Files          13       13              
  Lines        2478     2682     +204     
==========================================
- Hits         2206     2205       -1     
- Misses        272      477     +205     
Impacted Files Coverage Δ
src/frame/mod.rs 53.33% <ø> (ø)
src/frame/raw_decompress.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@PSeitz
Copy link
Owner

PSeitz commented Jul 17, 2023

I'm open to add async support, if the code is not duplicated.
There's also the risk of blocking the async runtime, by doing too much work on a task, so the additional plumbing may be a good thing.

Related issue: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants